feat(size): Log the binary analysis pool size at INFO - #673
Merged
Conversation
The worker count now comes from a sentry-option, but the only log that states it was at DEBUG, so nothing in Sentry Logs shows which value a build actually ran with. Emit it at INFO with a structured `workers` field so a region override can be verified from the build's logs.
Contributor
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
Contributor
📲 Install BuildsiOS
Android
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #672. With the Apple binary-analysis worker count now driven by the
size.binary_analysis.workersoption, there was no way to confirm from a build's logs which value it actually ran with: the only line that mentioned the count was at DEBUG, which Sentry Logs doesn't ingest.This emits
size.apple.binary_analysis_workersat INFO with a structuredworkersfield when the pool is created. A region override, such as thedevalue in getsentry/sentry-options-automator#9610, can then be verified by filtering the build's logs on that message and reading the field, and the same line shows the default elsewhere.The existing worker-stdout integration test now also asserts the line is emitted once with the configured count.